Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

Rewritten TLS howto #71

Merged
merged 7 commits into from Dec 23, 2021
Merged

Conversation

Tronic
Copy link
Member

@Tronic Tronic commented Oct 19, 2021

Expanded and clarified existing text, added the new features implemented in sanic-org/sanic#2270

The HTTP to HTTPS example was broken. Patched by using multiprocessing, but might need an update once that can be done without spawning extra processes. Also, neither app.url_for nor request.url_for is really suited for this, while a simple format string gets the job done nicely.

@sjsadowski
Copy link
Contributor

@Tronic is this ready to come out of draft?

@Tronic Tronic marked this pull request as ready for review October 25, 2021 08:26
@Tronic
Copy link
Member Author

Tronic commented Oct 25, 2021

@sjsadowski This must not be merged until after the next Sanic release with the TLS PR included (probably 21.12) is out. Maybe the docs should also mention that most of these options are new in this specific version.

@miss85246
Copy link
Contributor

Please give me some time. I need to check to see if there are any changes in the Chinese document. @sjsadowski @Tronic

@Tronic
Copy link
Member Author

Tronic commented Oct 26, 2021

@miss85246 Nearly all text has been rewritten. I recommend you copy&paste the English text to https://www.deepl.com/translator which does pretty good AI translation and then fix by hand.

@miss85246 几乎所有的文字都被重写了。我建议你把英文文本复制&粘贴到 https://www.deepl.com/translator ,它的人工智能翻译做得相当好,然后用手修正。

@ahopkins ahopkins changed the base branch from main to release21.12 December 23, 2021 12:34
@ahopkins ahopkins merged commit b32177b into sanic-org:release21.12 Dec 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants