Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flexibility in Extend declaration #22

Merged
merged 6 commits into from Dec 26, 2021
Merged

Add flexibility in Extend declaration #22

merged 6 commits into from Dec 26, 2021

Conversation

ahopkins
Copy link
Member

The main purpose of this is to make the integration into Sanic a little smoother. See sanic-org/sanic#2308

For example, the output to logs at startup are moved to a separate location so that the app can be extended either before or at startup time, and still have them generated in a consistent location.

@ahopkins ahopkins marked this pull request as draft December 16, 2021 06:20
@ahopkins
Copy link
Member Author

This should be ready once the core repo PR is merged.

@ahopkins ahopkins marked this pull request as ready for review December 26, 2021 10:30
@ahopkins ahopkins merged commit 86644b4 into main Dec 26, 2021
@ahopkins ahopkins deleted the ext-integration branch December 26, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant