-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm coverage of Vue component #1585
base: develop
Are you sure you want to change the base?
Conversation
app/javascript/scratch/example.vue
Outdated
return { | ||
message: 'Hello, World!', | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should be included in coverage, but is not currently tested
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1585 +/- ##
===========================================
- Coverage 90.82% 86.26% -4.56%
===========================================
Files 376 398 +22
Lines 7268 7654 +386
===========================================
+ Hits 6601 6603 +2
- Misses 667 1051 +384
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Code Climate has analyzed commit 0c421c2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.1% (0.0% change). View more on Code Climate. |
build: exclude Vue SFC from coverage stats until #1585 is addressed
Closes an investigation in to unexpectedly high code coverage stemming from #1520.
Once this issue has been resolved #1589 can be reverted.
Relates to:
Changes proposed in this pull request
Current reflected test coverage:
Line 11
andline 16
should be covered (green),line 21
should not be covered (red).Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main
]- Check story numbers included
- Check for debug code
- Check version