Skip to content

Commit

Permalink
Implement simpler workaround for auto-import #152
Browse files Browse the repository at this point in the history
emberjs/ember.js#19761 (comment)

Apparently, we can add auto-import `>= 2` to our devDependencies
without *crosses fingers* any issue...as long as we don’t need it
in our addon code.

This is a partial revert for PR #153.
  • Loading branch information
sandydoo committed Oct 13, 2021
1 parent b6c6838 commit 9ddf504
Show file tree
Hide file tree
Showing 3 changed files with 739 additions and 45 deletions.
30 changes: 2 additions & 28 deletions config/ember-try.js
Expand Up @@ -34,24 +34,16 @@ module.exports = async function () {
{
name: 'ember-beta',
npm: {
dependencies: {
'ember-auto-import': '^2.0.0',
},
devDependencies: {
'ember-source': await getChannelURL('beta'),
webpack: '^5.0.0',
},
},
},
{
name: 'ember-canary',
npm: {
dependencies: {
'ember-auto-import': '^2.0.0',
},
devDependencies: {
'ember-source': await getChannelURL('canary'),
webpack: '^5.0.0',
},
},
},
Expand Down Expand Up @@ -83,26 +75,8 @@ module.exports = async function () {
},
},
},
embroiderSafe({
npm: {
dependencies: {
'ember-auto-import': '^2.0.0',
},
devDependencies: {
webpack: '^5.0.0',
},
},
}),
embroiderOptimized({
npm: {
dependencies: {
'ember-auto-import': '^2.0.0',
},
devDependencies: {
webpack: '^5.0.0',
},
},
}),
embroiderSafe(),
embroiderOptimized(),
],
};
};
4 changes: 3 additions & 1 deletion package.json
Expand Up @@ -68,6 +68,7 @@
"babel-eslint": "^10.1.0",
"broccoli-asset-rev": "^3.0.0",
"dotenv": "^10.0.0",
"ember-auto-import": "^2.2.2",
"ember-cli": "~3.25.3",
"ember-cli-addon-tests": "^0.11.1",
"ember-cli-dependency-checker": "^3.2.0",
Expand Down Expand Up @@ -96,7 +97,8 @@
"qunit": "^2.16.0",
"qunit-dom": "^1.6.0",
"release-it": "^14.10.1",
"release-it-lerna-changelog": "^3.1.0"
"release-it-lerna-changelog": "^3.1.0",
"webpack": "^5.58.2"
},
"engines": {
"node": "10.* || >= 12"
Expand Down

0 comments on commit 9ddf504

Please sign in to comment.