Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows rubyzip >= 1.3.0 and fixes tests. Fixes #98 #99

Merged
merged 1 commit into from Oct 10, 2019
Merged

Allows rubyzip >= 1.3.0 and fixes tests. Fixes #98 #99

merged 1 commit into from Oct 10, 2019

Conversation

vtamara
Copy link
Contributor

@vtamara vtamara commented Sep 26, 2019

No description provided.

@vtamara vtamara changed the title Allows rubyzip >= 1.3.0 and fixes tests Allows rubyzip >= 1.3.0 and fixes tests. Fixes #98 Sep 30, 2019
@vtamara
Copy link
Contributor Author

vtamara commented Sep 30, 2019

Fixes #98

@jaredbeck
Copy link
Contributor

Should this PR set Zip.validate_entry_sizes = true (per instructions) or should that be the responsibility of our applications?

@vtamara
Copy link
Contributor Author

vtamara commented Sep 30, 2019

In my projects I'm using rubyzip 2.0.0 where Zip.validate_entry_sizes is true by default.

I guess for 1.3.x it would be a good idea. In what file of odf-report would you put Zip.validate_entry_sizes = true ?

@jaredbeck
Copy link
Contributor

In my projects I'm using rubyzip 2.0.0 where Zip.validate_entry_sizes is true by default.

Thanks Vladimir, I am using rubyzip 2.0.0 now (I am using your fork).

@jaredbeck
Copy link
Contributor

@sandrods Please review, this PR fixes a known security vulnerability (CVE-2019-16892)

@sandrods sandrods merged commit e1bfd46 into sandrods:master Oct 10, 2019
@sandrods
Copy link
Owner

sorry it took me so long.
PR Merged.
GEM Pushed.

Thanks!

@jaredbeck
Copy link
Contributor

Thanks Sandro! Thanks Vladimir!

@vtamara vtamara deleted the rubyzip-1.3 branch October 11, 2019 00:19
@vtamara
Copy link
Contributor Author

vtamara commented Oct 11, 2019

Thanks .
Welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vtamara @jaredbeck @sandrods