Replace queries using at_css with at_xpath to prevent incompatibility…

… with new version of Nokogiri. See #120
sandrods · Feb 23, 2022 · 1fb39e1 · 1fb39e1 · sandrods · Feb 23, 2022
1 parent 16f5b38
commit 1fb39e1
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 9 deletions.
diff --git a/lib/odf-report/section.rb b/lib/odf-report/section.rb
@@ -26,11 +26,11 @@ def replace!(doc)
   private
 
     def find_section_node(doc)
-      @section_node = doc.at_css("text|section[@text|name='#{@name}']")
+      @section_node = doc.at_xpath("//text:section[@text:name='#{@name}']")
     end
 
     def deep_clone(node)
-      Nokogiri::XML(wrap_with_ns(node)).at("text|section")
+      Nokogiri::XML(wrap_with_ns(node)).at_xpath("//text:section")
                                        .tap { |n| n.attribute('name').content = SecureRandom.uuid }
 
     end

diff --git a/lib/odf-report/table.rb b/lib/odf-report/table.rb
@@ -60,7 +60,6 @@ def get_next_row
       end
 
       return deep_clone(ret)
-      # return ret.dup
     end
 
     def get_start_node
@@ -72,11 +71,11 @@ def template_length
     end
 
     def find_table_node(doc)
-      doc.at_css("table|table[@table|name='#{@name}']")
+      doc.at_xpath("//table:table[@table:name='#{@name}']")
     end
 
     def deep_clone(node)
-      Nokogiri::XML(wrap_with_ns(node)).at("table|table-row")
+      Nokogiri::XML(wrap_with_ns(node)).at_xpath("//table:table-row")
     end
 
   end

diff --git a/spec/images_spec.rb b/spec/images_spec.rb
@@ -116,8 +116,8 @@
     end
 
     it "removes nil images in report" do
-      expect(@data.xml.at_css("draw|frame[@draw|name='IMAGE_01']")).to be
-      expect(@data.xml.at_css("draw|frame[@draw|name='IMAGE_02']")).to be_nil
+      expect(@data.xml.at_xpath(".//draw:frame[@draw:name='IMAGE_01']")).to be
+      expect(@data.xml.at_xpath(".//draw:frame[@draw:name='IMAGE_02']")).to be_nil
     end
 
     it "removes nil images in tables" do

diff --git a/spec/sections_spec.rb b/spec/sections_spec.rb
@@ -38,12 +38,12 @@
   end
 
   it "should remove section with empty collection" do
-    section = @data.xml.at_css("text|section[@text|name='SECTION_02']")
+    section = @data.xml.at_xpath("//text:section[@text:name='SECTION_02']")
     expect(section).to be_nil
   end
 
   it "should remove section with nil collection" do
-    section = @data.xml.at_css("text|section[@text|name='SECTION_03']")
+    section = @data.xml.at_xpath("//text:section[@text:name='SECTION_03']")
     expect(section).to be_nil
   end