Support mypy 0.910 to 0.930 including CI tests #3594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Right now, pypi is partially down, hence all the failures, see here. |
3 tasks
|
@christianbundy, @PrettyWood I'd love you feedback on this. I still need to get tests passing once pypi is back up and add a change description. |
christianbundy
approved these changes
Dec 29, 2021
samuelcolvin
changed the title
|
LGTM. I'll merge tomorrow. |
ntaylorwss
pushed a commit
to nicejobinc/pydantic
that referenced
this pull request
Jun 24, 2022
* cleanup bumping mypy to 0.930, pydantic#3573 * add tests for old mypy * tweak test-old-mypy job * alter mypy plugin to work with older versions * mypy.py compatibility with multiple versions * fix mypy tests to allow for varied output * toml parsing, fix pydantic#3579 * formatting :-( * ignore missing types for toml package * remove unused ignore_missing_imports * undo removal of ignore_missing_imports for dotenv * tweak coverage ignore * fully uninstall mypy and toml/tomli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup from #3573, also stealing logic from #3572.
I normally don't think changing the versions of mypy which the plugin is compatible with would be a problem in a minor release, but since we've already made two beta release of v1.9, breaking mypy compatibility now would be ugly.