Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support and test mypy 0.910, 0.920, and 0.921 #3572

Closed
wants to merge 9 commits into from
Closed

Support and test mypy 0.910, 0.920, and 0.921 #3572

wants to merge 9 commits into from

Conversation

christianbundy
Copy link
Contributor

@christianbundy christianbundy commented Dec 24, 2021 •
edited

Change Summary

Problem: We aren't testing mypy version compatibility, which makes it hard to know when we're making/breaking compatibility. In my local testing, it seems that we've recently broken mypy 0.910 compatibility.

Solution: Add mypy version matrix to CI and fix compatibility regressions.

Related issue number

Link: #3538 (comment)

See-also: #3175

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@christianbundy
Add mypy version matrix to CI
e1af942
@christianbundy
Fix job names
fcb048b
@christianbundy
Fix supported mypy versions
a6584ba
@christianbundy
Revert backward-incompatible changes
b58782a 
This reverts commit e14e756.
@christianbundy
Appease linter
1ddfbb8 
When I upgraded mypy I started getting new mypy and flake8 errors. I
understand the mypy linter errors, but I'm confused at why I got the
flake8 ones now.
@christianbundy
Remove irrelevant comment
6efe9ce
@christianbundy
Revert changes from odd new flake8 rules
b7c3624 
This reverts commit 1ddfbb8.
@christianbundy christianbundy changed the title Add mypy version matrix to CI Fix compatibility for mypy 0.910 and add support (and tests) for mypy 0.921 Dec 24, 2021
@christianbundy christianbundy changed the title Fix compatibility for mypy 0.910 and add support (and tests) for mypy 0.921 Support and test mypy 0.910, 0.920, and 0.921 Dec 24, 2021
@christianbundy
Copy link
Contributor Author

please review

@christianbundy christianbundy marked this pull request as ready for review December 24, 2021 18:57
@samuelcolvin
Copy link
Member

samuelcolvin commented Dec 29, 2021 •
edited

Thanks for this, I'm stealing some ideas for #3594.

@samuelcolvin samuelcolvin mentioned this pull request Dec 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelcolvin samuelcolvin samuelcolvin left review comments

Assignees

@samuelcolvin samuelcolvin

@PrettyWood PrettyWood

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christianbundy @samuelcolvin @PrettyWood