fix: keep old behaviour of json() by default
#3542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review |
PrettyWood
force-pushed
the
fallback-encoder
branch
2 times, most recently
from
7873253
to
898a9c1
Compare
|
If you don't want to delay v1.9 then reverting #2650 might be the best course of action for the time being? |
|
Yeah I saw new issues pop up. I will take some time tomorrow to check properly. But if no easy workaround is possible, I'll revert #2650 |
3 tasks
PrettyWood
force-pushed
the
fallback-encoder
branch
from
898a9c1
to
1a8205b
Compare
PrettyWood
changed the title
json() by default
PrettyWood
force-pushed
the
fallback-encoder
branch
from
1a8205b
to
07062b2
Compare
|
@PrettyWood did you have time to think about this? I've haven't dug into it in detail, but I will try to find time soon. |
|
FWIW after the force-push this seems to solve the problem (and adds a test from #3544). At least from my perspective, this looks Fine™️. |
|
This should solve everything yes |
|
awesome, thank you. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
fix regression on 1.9 introduced in #2650 (see #3538 (reply in thread))
Related issue number
Checklist
Documentation reflects the changes where applicablechanges/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)