New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: keep old behaviour of json()
by default
#3542
Conversation
please review |
7873253
to
898a9c1
Compare
If you don't want to delay v1.9 then reverting #2650 might be the best course of action for the time being? |
Yeah I saw new issues pop up. I will take some time tomorrow to check properly. But if no easy workaround is possible, I'll revert #2650 |
898a9c1
to
1a8205b
Compare
json()
by default
1a8205b
to
07062b2
Compare
@PrettyWood did you have time to think about this? I've haven't dug into it in detail, but I will try to find time soon. |
FWIW after the force-push this seems to solve the problem (and adds a test from #3544). At least from my perspective, this looks Fine™️. |
This should solve everything yes |
awesome, thank you. |
Change Summary
fix regression on 1.9 introduced in #2650 (see #3538 (reply in thread))
Related issue number
Checklist
Documentation reflects the changes where applicable(I didn't add a change file since it's due to a new feature of 1.9)changes/<pull request or issue id>-<github username>.md
file added describing change(see changes/README.md for details)