Remove __root__ from BaseModel typing-only attrs
#3540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`__root__` is not a class variable nor is it always present. The switch to `ClassVar` caused type errors to be reported in Pylance/Pyright.
|
please review |
|
Thanks so much, looks like it was added back in the original implementation of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
__root__is not a class variable nor is it always present.The switch to
ClassVarcaused type errors to be reported in Pylance/Pyright.Related issue number
—
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)