Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove __root__ from BaseModel typing-only attrs #3540

Merged
merged 2 commits into from Dec 19, 2021
Merged

Remove __root__ from BaseModel typing-only attrs #3540

merged 2 commits into from Dec 19, 2021

Commits on Dec 19, 2021

  1. Remove __root__ from BaseModel typing-only attrs 

    `__root__` is not a class variable nor is it always present.

The switch to `ClassVar` caused type errors to be reported in Pylance/Pyright.
    @layday
    layday committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    6376d7e View commit details
    Browse the repository at this point in the history

  2. Add changelog entry

    @layday
    layday committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    bf77fd3 View commit details
    Browse the repository at this point in the history