Add AmqpDsn class
#3254
Merged
Add AmqpDsn class
#3254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will update once finished - haven't looked at the CONTRIB yet. Want to test locally to see if it works.
|
The image is from #2049 (review).
I don't understand what I'm supposed to add, as there's a description talking about |
Kludex
commented
Sep 23, 2021
docs/examples/settings_main.py
Outdated
| @@ -21,6 +22,7 @@ class Settings(BaseSettings): | |||
|
|
|||
| redis_dsn: RedisDsn = 'redis://user:pass@localhost:6379/1' | |||
| pg_dsn: PostgresDsn = 'postgres://user:pass@localhost:5432/foobar' | |||
| rabbitmq_dsn: RabbitMqDsn = 'amqp://guest:guest@rabbitmq:5672//' | |||
There was a problem hiding this comment.
/ is the default vhost. Should I explain something about it? If yes, where?
|
please review 😉 |
|
Hi @Kludex! |
|
Whatever name suits people better is fine by me. I just want the type for AMPQ. But I can also include the other protocols supported for RabbitMQ. For the two other comments, I'll address later on. Thank you! |
samuelcolvin
reviewed
Dec 8, 2021
|
please update. |
Kludex
commented
Dec 12, 2021
|
please review |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This PR is a continuation of #2049. I've respectfully maintained the commits, and fix the code according to @samuelcolvin previous comments.
I've also changed the name of the class
RabbitmqDsntoRabbitMqDsn. As the "MQ" case should follow a similar analogy to "DSN".Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)