Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AmqpDsn mis-documented as RabbitMqDsn #4762

Closed
5 of 15 tasks
keyz182 opened this issue Nov 16, 2022 · 2 comments · Fixed by #4825
Closed
5 of 15 tasks

AmqpDsn mis-documented as RabbitMqDsn #4762

keyz182 opened this issue Nov 16, 2022 · 2 comments · Fixed by #4825

Comments

@keyz182
Copy link

keyz182 commented Nov 16, 2022

Initial Checks

  • I have searched GitHub for a duplicate issue and I'm sure this is something new
  • I have searched Google & StackOverflow for a solution and couldn't find anything
  • I have read and followed the docs and still think this is a bug
  • I am confident that the issue is with pydantic (not my code, or another library in the ecosystem like FastAPI or mypy)

Description

AmqpDsn introduced in #3254 is documented as RabbitMqDsn.
See:

`RabbitMqDsn`

Example Code

N/A

Python, Pydantic & OS Version

pydantic version: 1.10.2
            pydantic compiled: True
                 install path: /home/keyz/Code/Simbachain/block-service/.venv/lib/python3.10/site-packages/pydantic
               python version: 3.10.6 (main, Nov  2 2022, 18:53:38) [GCC 11.3.0]
                     platform: Linux-5.15.68.1-microsoft-standard-WSL2-x86_64-with-glibc2.35
     optional deps. installed: ['dotenv', 'email-validator', 'typing-extensions']

Affected Components

@keyz182 keyz182 added bug V1 Bug related to Pydantic V1.X unconfirmed Bug not yet confirmed as valid/applicable labels Nov 16, 2022
@hramezani
Copy link
Member

Thanks @keyz182 for reporting! You are right.

Would you like to create a patch and fix it?

@hramezani hramezani added documentation and removed bug V1 Bug related to Pydantic V1.X unconfirmed Bug not yet confirmed as valid/applicable labels Dec 5, 2022
@keyz182
Copy link
Author

keyz182 commented Dec 16, 2022

Apologies, I've been unwell. Thanks for fixing though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants