Support user defined generic field types in generic models for python < 3.9. #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviskirk
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2554 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 5109 5109
Branches 1050 1050
=========================================
Hits 5109 5109
Continue to review full report at Codecov.
|
daviskirk
commented
Mar 20, 2021
PrettyWood
reviewed
Mar 24, 2021
daviskirk
force-pushed
the
support-user-defined-generic-fields-for-generic-models
branch
2 times, most recently
from
213500a
to
661c3b3
Compare
Work on pydantic#2465 (see comments)
daviskirk
force-pushed
the
support-user-defined-generic-fields-for-generic-models
branch
from
661c3b3
to
38dce40
Compare
|
Rebased on master to fix tests |
|
thanks so much. |
samuelcolvin
added a commit
that referenced
this pull request
May 11, 2021
Work on #2465 (see comments) Co-authored-by: Samuel Colvin <s@muelcolvin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for user defined generic type fields in generic models for python < 3.9.
Referencing this comment (and the problem described) here: #2465 (comment)
Change Summary
The actual change (the check for
type_.name_) is not necessary in python >= 3.9 as described in the code comment but is needed for python < 3.9.Related issue number
Work on #2465 (see comments)
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)