Support user defined generic field types in generic models for python < 3.9. #2554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for user defined generic type fields in generic models for python < 3.9.
Referencing this comment (and the problem described) here: #2465 (comment)
Change Summary
The actual change (the check for
type_.name_
) is not necessary in python >= 3.9 as described in the code comment but is needed for python < 3.9.Related issue number
Work on #2465 (see comments)
Checklist
changes/<pull request or issue id>-<github username>.md
file added describing change(see changes/README.md for details)