remove specific psych gem version dependency #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samrjenkins
force-pushed
the
remove-explicit-psych-version
branch
from
3169a4f
to
009a9c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rubocop gem experimented with adding Psych as a runtime dependency. This didn't work and they reverted the move:
rubocop/rubocop#6885
According to the Rubocop PR above, Psych is tightly coupled to Ruby core and it is dangerous to spec a specific Psych version without requiring a matching Ruby version.
Instead, we should rely on the version of Psych shipped with the Ruby version being used.