Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align CJS main entrypoint and its index.d.ts #109

Merged
merged 3 commits into from Jan 16, 2022

Conversation

imcotton
Copy link
Contributor

@imcotton imcotton commented Jan 15, 2022

In order to supporting both:

import { number } from 'fp-ts-std'

or

const { number } = require('fp-ts-std')

Where supported prior to v0.12

SimonAM and others added 3 commits December 30, 2021 19:07
has link to fp-ts-std 
should be link to fp-ts
Update docs at ramda-comparison.md
@samhh
Copy link
Owner

samhh commented Jan 16, 2022

Good spot. I'm surprised index isn't captured by the *.

Is the types key correct? Is it relative to typesVersions?

@imcotton
Copy link
Contributor Author

Is the types key correct? Is it relative to typesVersions?

It's kinda tricky, here is the reference: microsoft/TypeScript#43034 (comment)

@samhh samhh changed the base branch from master to develop January 16, 2022 22:52
@samhh
Copy link
Owner

samhh commented Jan 16, 2022

Gotcha. Thanks for your contribution! I'll make a point release including this fix.

@samhh samhh merged commit ffd8388 into samhh:develop Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants