New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3007.x] Fix #66194: Exchange HTTPClient by AsyncHTTPClient in salt.utils.http #66330
base: 3007.x
Are you sure you want to change the base?
Conversation
Hey @krombel , since this effects 3007, would you mind rebasing this against the 3007.x branch? |
@twangboy done |
@krombel Would you know how to write a test for this? |
I attempted this patch but got this error:
|
@twangboy Sadly no. There are no related tests (I could find and adapt) and I am not familiar with python testing... @ITJamie After you mentioned it I somehow could reproduce it. I don't know why it worked in the first place but now I introduced the SyncWrapper which allows calling fetch() in a sync manner. A "proper" fix would possibly be to make query an async function (so we can simply |
What does this PR do?
It replaces HTTPClient by AsyncHTTPClient
What issues does this PR fix or reference?
Fixes #66194
Background
tornadoweb/tornado#2325 (comment)
==> might be caused by #64304
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes