[3006.x] - Handling GitFS locking issue and resource loss due to SIGTERM not clearing up #65937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
May 22, 2024 13:34
…e - psutil.process(pid) doesn't give register function
dmurphy18
dismissed
s0undt3ch’s stale review
Refractored a lot of the objectionable code, requires a new review
|
@s0undt3ch @dwoz Can you re-review, refactored the objectionable code in SIGTERM handling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolves missing unlock issue with GitFS, that is, lock but no unlock.
Also ensure that when a process is SIGTERM, it cleans up and releases resources held, namely lock files.
Process generated lGitFS lock files, but failed to clear the lock files, and when the process was finally SIGTERM (due to connection being closed by sseapi remote end, 14 minutes later), failed to clean up any resources allocated, namely the GitFS lock files.
What issues does this PR fix or reference?
Fixes:#65816
Previous Behavior
Process left GitFs lock files present which had to be cleaned up by hand.
New Behavior
Process no longer leaves GitFs lock files present, and checks when terminated (SIGTERM) and cleans up any GitFS lock files which it generated.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.