Pin request install to version for npm tests #43196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fails on centos 6 because its node is too old to support the version of hawk bumped here request/request#2751, we can still test the functionality. This will pull from github, and install a specific tag version, and we still do the uninstall using the github path. This should be more stable.
|
@gtmanfred, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dougluce, @terminalmage and @whiteinge to be potential reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fails on centos 6 because its node is too old to support the version of
hawk bumped here request/request#2751, we can still
test the functionality. This will pull from github, and install a specific tag
version, and we still do the uninstall using the github path.
This should be more stable.
What issues does this PR fix or reference?
Fixes saltstack/salt-ci-images#495
Tests written?
Yes