Upgrade to rubocop 1.0 and rubocop-rspec 2.0 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikkessler1
changed the title
jturkel
approved these changes
Nov 20, 2020
| @@ -37,3 +37,6 @@ RSpec/NestedGroups: | |||
|
|
|||
| RSpec/ContextWording: | |||
| Enabled: false | |||
|
|
|||
| RSpec/MultipleMemoizedHelpers: | |||
| Enabled: false | |||
There was a problem hiding this comment.
I definitely agree disabling this is the right call!
pirj
reviewed
Feb 5, 2021
|
|
||
| # Inspired by: | ||
| # https://github.com/rubocop-hq/rubocop-rspec/blob/cecc4b3f648002811c3956c1338431ecd4186aef/spec/shared/default_rspec_language_config_context.rb | ||
| RSpec.shared_context "with default RSpec/Language config", :config do |
There was a problem hiding this comment.
We had an idea to extract this file into lib/, so third-party gems can use it. A pull request is welcome if you decide to drop this file and use this shared context directly from rubocop-rspec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our rubocop and rubocop-rspec dependencies to 1.0 and 2.0 respectively.
A change to how RSpec language elements are defined/configured (rubocop/rubocop-rspec#956) broke some of our custom RSpec cops as we can no longer do things like:
RuboCop::RSpec::Language::Examples::ALL. I've updated these cops to use the new best-practices from the upgrade guides.rubocop-rspecupgrade notesrubocopupgrade notesNew Cops
Updating to
rubocop-rspecv2.0 will enabled the following cops:RSpec/RepeatedExampleGroupBodyRSpec/RepeatedExampleGroupDescriptionRSpec/EmptyHookRSpec/VariableDefinitionRSpec/VariableNameRSpec/MultipleMemoizedHelpers(disabled as we have lots of offenses)RSpec/RepeatedIncludeExampleRSpec/StubbedMockprime: @jturkel