Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch removed util methods for vows #389

Merged
merged 1 commit into from
Mar 19, 2024
Merged

patch removed util methods for vows #389

merged 1 commit into from
Mar 19, 2024

Conversation

wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Mar 18, 2024

Vows is a legacy test suite, and we plan on removing it eventually, but in the meantime it would be nice if it actually worked. To see the intended output when tests fail, we need to patch util.patch and util.puts.

Copy link
Member

@awaterma awaterma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@wjhsf wjhsf merged commit e2151b6 into master Mar 19, 2024
6 checks passed
@wjhsf wjhsf deleted the vows-patch-util-print branch March 19, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants