Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Jest@18 and latest version of LWC #275

Merged
merged 2 commits into from Jun 1, 2022
Merged

Conversation

pmdartus
Copy link
Member

@pmdartus pmdartus commented May 25, 2022

Notable changes:

  • Upgrade to Jest@18
  • Move all the @lwc/jest-* and jest to use ^ for version matching. Internally all the packages are using ^ and therefore freezing the top-level package has no effect.

Fixes #274.

@pmdartus
Copy link
Member Author

This PR fails to run against https://github.com/trailheadapps/lwc-recipes. I will keep investigating this.

@pmdartus
Copy link
Member Author

Ignore my previous comment, after further investigation, the error was caused by some local misconfiguration. This PR can be reviewed.

Copy link
Member

@ekashida ekashida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the release flow for this project change recently? IIRC, we used to make all changes in prerelease until the major release hit production, at which time prerelease would be merged into master.

@jye-sf
Copy link
Contributor

jye-sf commented May 31, 2022

It looks like prerelease hasn't been used since Jan 2021. All the changes since then have been going into master. Then in March of this year the documentation around prerelease was removed: #265.

@pmdartus pmdartus merged commit 9922782 into master Jun 1, 2022
@pmdartus pmdartus deleted the pmdartus/jest18 branch June 1, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Jest v28
4 participants