chore: standardize release script #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've noticed we rarely update the version on this project, so I'm assuming we're publishing with the same version. Is that intentional, or should I be adding a version update into the process? |
|
@jye-sf I think we just haven't released in a while because there was nothing to change. When we do a release, we should bump the version. |
nolanlawson
reviewed
Apr 12, 2022
jye-sf
commented
Apr 12, 2022
| @@ -27,7 +27,9 @@ | |||
| "lint": "eslint src/ tests/", | |||
| "format": "prettier --write '**/*.{js,json,md,html,css}'", | |||
| "format:check": "prettier --check '**/*.{js,json,md,html,css}'", | |||
| "release": "npm publish --access public", | |||
| "release": "yarn release:publish", | |||
There was a problem hiding this comment.
Full service command will require a script that can read args (for version upgrade) and proper permissions to merge into master. Keeping this script as-is until we have that functionality.
jye-sf
commented
Apr 13, 2022
package.json
Outdated
| "release": "yarn release:publish", | ||
| "release:version": "npm version", | ||
| "release:publish": "npm publish --access public --registry=https://registry.npmjs.org", | ||
| "release:publish:ci": "npm publish --access public --registry=https://registry.npmjs.org --dry-run", |
There was a problem hiding this comment.
Will remove --dry-run after review for safety.
nolanlawson
reviewed
Apr 13, 2022
| executors: | ||
| node: | ||
| docker: | ||
| - image: circleci/node:14 |
There was a problem hiding this comment.
Suggested change
| - image: circleci/node:14 | |
| - image: cimg/node:14.19.1 |
nolanlawson
reviewed
Apr 13, 2022
.circleci/config.yml
Outdated
Comment on lines
30
to
32
| keys: | ||
| - v1-yarn-deps-{{ checksum "yarn.lock" }} | ||
| - v1-yarn-deps- |
There was a problem hiding this comment.
Suggested change
| keys: | |
| - v1-yarn-deps-{{ checksum "yarn.lock" }} | |
| - v1-yarn-deps- | |
| key: v1-yarn-deps-{{ checksum "yarn.lock" }} |
nolanlawson
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize the naming for our release scripts:
yarn release -> full service release
yarn release:version -> update the version
yarn release:publish -> publish the project