Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bumps [guava](https://github.com/google/guava) from 29-jre to 30.1.1-jre #28

Merged
merged 1 commit into from Jul 22, 2021

Conversation

eperret
Copy link
Member

@eperret eperret commented Jul 22, 2021

Updated to address an identified issue

Guava Changelog

  • Increased the aggressiveness of Guava 30.1's warning log message for running guava-android under a Java 7 VM. (Android VMs are unaffected.) If the warning itself causes you trouble, you can eliminate it by silencing the logger for com.google.common.base.Preconditions (which is used only for this warning). This warning prepares for removing support for Java 7 in 2021. Please report any problems. We have tried to make the warning as safe as possible, but anytime a common library logs, especially as aggressively as we do in this new release, there is the potential for NullPointerException or even deadlock. (To be clear, Guava will not log under Java 8 or Android, but it will under Java 7.) (00c25e9)
  • cache: Fixed compatibility between asMap().compute(...) and a load. (42bf4f4)
  • cache: Added @CheckReturnValue to some APIs. (a5ef129)
  • collect: Added @DoNotCall to the mutator methods on immutable types (6ae9532)
  • hash: Removed @Beta from HashCode. (2c9f161)
  • io: Removed @Beta from CountingOutputStream.
    (d394bac)i
  • If you use guava-android in an Android project (as opposed to from a Java VM), you will need to enable desugaring of Java 8 language features if you have not already done so. (And if you are releasing an Android library, then anyone who uses that library will also have to enable desugaring.) We expect for nearly all Android projects to have already enabled desugaring. But if this causes problems for you, please let us know on issue #5358. The purpose of this change is to detect potential problems for users now so that we can plan to use Java 8 language features in our implementation later this year.
  • Introduced a warning log message when running guava-android under a Java 7 VM. (Android VMs are unaffected, aside from the need to use desugaring, described in the previous bullet.) This warning is not guaranteed to be logged when running under Java 7, so please don't rely on it as your only warning about future problems. If the warning itself causes you trouble, you can eliminate it by silencing the logger for com.google.common.base.MoreObjects$ToStringHelper (which is used only for this warning). This warning prepares for removing support for Java 7 in 2021. Please report any problems. We have tried to make the warning as safe as possible, but anytime a common library logs, there is the potential for NullPointerException or even deadlock. (To be clear, Guava will not log under Java 8 or Android, but it may log under Java 7.) (dc52e6e)
    • Note that we subsequently made this warning more aggressive in Guava 30.1.1, including changing the logger it uses to com.google.common.base.Preconditions.
  • base: Deprecated StandardSystemProperty.JAVA_EXT_DIRS. We do not plan to remove the API, but note that, under recent versions of Java, that property always has a value of null. (38abf07)
  • net: Added HttpHeaders constants for Origin-Isolation and X-Request-ID. (a48fb4f, 8319d20)
  • reflect: Added ClassInfo.isTopLevel(). (4106272)
  • util.concurrent: Added ClosingFuture.submitAsync(AsyncClosingCallable). (c5e2d8d)
  • Guava types can no longer be sent over GWT-RPC. Even the earlier, temporary way to reenable support (guava.gwt.emergency_reenable_rpc) no longer has an effect. (0cb89dd)
  • cache: Fixed memory leak in LocalCache under j2objc. (5e519d9)
  • collect: Added two-element min and max methods to Comparators. (958186c)
  • collect: Removed @Beta from Multimaps.toMultimap. (b6b4dc4)
  • collect: Made the set returned by ImmutableMap<K, V>.keySet() serializable as long as K is serializable, even if V is not (and similarly for values()). (f5a69c3)
  • collect: Fixed bug in powerSet.equals(otherPowerSet) would erroneously return false if the two power sets' underlying sets were equal but had a different iteration order. (215b1f0)
  • collect: Eliminated j2objc retain-cycle in SingletonImmutableBiMap. (0ad38b8)
  • eventbus: Prevented @Subscribe from being applied to a method that takes a primitive, as that will never be called. (554546c)
  • graph: Made Traverser.breadthFirst() lazier, and optimized Traverser more generally. (32f2d77, b5210ca)
  • graph: Added @DoNotMock to Traverser. (6410f18)
  • io: Deprecated Files.createTempDir(). (fec0dbc) (CVE-2020-8908; continuing discussion in #4011)
  • io: Upgraded ByteStreams.copy(InputStream, OutputStream) to use the faster FileChannel if possible. (a1e9a0b) [update: My mistake: This was rolled back, so it did not make 30.0.]
  • math: Added roundToDouble to BigDecimalMath, BigIntegerMath, and LongMath. (bee4f3c, 2b5c096, 633abf2)
  • net: Added MediaType constants for several font/ types. (571cf66)
  • net: Added HttpHeaders constants for Cross-Origin-Embedder-Policy(-Report-Only)?. (c3bf731)
  • testing: Made EqualsTester test that non-String objects are not equal to their String representations. (c9570ea)
  • util.concurrent: Added ClosingFuture. (52e048e)
  • util.concurrent: Removed the deprecated 1-arg ServiceManager.addListener(Listener). Use the 2-arg addListener(Listener, Executor) overload, setting the executor to directExecutor() for equivalent behavior. (dfb0001)
  • util.concurrent: Changed AbstractFuture.toString() to no longer include the toString() of the result. (2ebf27f)
  • util.concurrent: Added awaitTerminationUninterruptibly. (f07b954)

…e to 30.1.1-jre

Updated to addres an identified issue
-   `io`: Deprecated  `Files.createTempDir()`. ([fec0dbc](google/guava@fec0dbc)) ([CVE-2020-8908](https://nvd.nist.gov/vuln/detail/CVE-2020-8908); continuing discussion in  [#4011](google/guava#4011))

-   Increased the aggressiveness of  [Guava 30.1](https://github.com/google/guava/releases/tag/v30.1)'s warning log message for running  `guava-android`  under a Java 7 VM. (Android VMs are unaffected.) If the warning  _itself_  causes you trouble, you can eliminate it by silencing the logger for  `com.google.common.base.Preconditions`  (which is used  _only_  for this warning). This warning prepares for  [removing support for Java 7 in 2021](google/guava#5269). Please report any problems. We have tried to make the warning as safe as possible, but anytime a common library logs, especially as aggressively as we do in this new release, there is the potential for  [`NullPointerException`](https://stackoverflow.com/a/41017717/28465)  or even  [deadlock](https://stackoverflow.com/a/48009613/28465). (To be clear, Guava will not log under Java 8 or Android, but it will under Java 7.) ([00c25e9](google/guava@00c25e9))
-   `cache`: Fixed compatibility between  `asMap().compute(...)`  and a load. ([42bf4f4](google/guava@42bf4f4))
-   `cache`: Added  `@CheckReturnValue`  to some APIs. ([a5ef129](google/guava@a5ef129))
-   `collect`: Added  `@DoNotCall`  to the mutator methods on immutable types ([6ae9532](google/guava@6ae9532))
-   `hash`: Removed  `@Beta`  from  `HashCode`. ([2c9f161](google/guava@2c9f161))
-   `io`: Removed  `@Beta`  from  `CountingOutputStream`.
([d394bac](google/guava@d394bac847467039530f514f880ecca27263d0ff))i
-   If you use guava-android in an Android project (as opposed to from a Java VM), you will need to  [enable desugaring of Java 8  _language features_](https://developer.android.com/studio/write/java8-support.html#supported_features)  if you have not already done so. (And if you are releasing an Android  _library_, then anyone who uses that library will also have to enable desugaring.) We expect for nearly all Android projects to have already enabled desugaring. But if this causes problems for you, please let us know on  [issue #5358](google/guava#5358). The purpose of this change is to detect potential problems for users now so that we can plan to use Java 8 language features in our implementation later this year.
-   Introduced a warning log message when running  `guava-android`  under a Java 7 VM. (Android VMs are unaffected, aside from the need to use desugaring, described in the previous bullet.) This warning is not  _guaranteed_  to be logged when running under Java 7, so please don't rely on it as your only warning about future problems. If the warning  _itself_  causes you trouble, you can eliminate it by silencing the logger for  `com.google.common.base.MoreObjects$ToStringHelper`  (which is used  _only_  for this warning). This warning prepares for  [removing support for Java 7 in 2021](google/guava#5269). Please report any problems. We have tried to make the warning as safe as possible, but anytime a common library logs, there is the potential for  [`NullPointerException`](https://stackoverflow.com/a/41017717/28465)  or even  [deadlock](https://stackoverflow.com/a/48009613/28465). (To be clear, Guava will  _not_  log under Java 8 or Android, but it  _may_  log under Java 7.) ([dc52e6e](google/guava@dc52e6e))
    -   Note that we subsequently made this warning more aggressive in  [Guava 30.1.1](https://github.com/google/guava/releases/tag/v30.1.1), including changing the logger it uses to  `com.google.common.base.Preconditions`.
-   `base`: Deprecated  `StandardSystemProperty.JAVA_EXT_DIRS`. We do not plan to remove the API, but note that, under recent versions of Java, that property always has a value of  `null`. ([38abf07](google/guava@38abf07))
-   `net`: Added  `HttpHeaders`  constants for  `Origin-Isolation`  and  `X-Request-ID`. ([a48fb4f](google/guava@a48fb4f),  [8319d20](google/guava@8319d20))
-   `reflect`: Added  `ClassInfo.isTopLevel()`. ([4106272](google/guava@4106272))
-   `util.concurrent`: Added  `ClosingFuture.submitAsync(AsyncClosingCallable)`. ([c5e2d8d](google/guava@c5e2d8d))
-   [Guava types can no longer be sent over GWT-RPC.](https://groups.google.com/d/msg/guava-announce/zHZTFg7YF3o/rQNnwdHeEwAJ)  Even the earlier, temporary way to reenable support (`guava.gwt.emergency_reenable_rpc`) no longer has an effect. ([0cb89dd](google/guava@0cb89dd))
-   `cache`: Fixed memory leak in  `LocalCache`  under  [j2objc](https://developers.google.com/j2objc). ([5e519d9](google/guava@5e519d9))
-   `collect`: Added two-element  `min`  and  `max`  methods to  `Comparators`. ([958186c](google/guava@958186c))
-   `collect`: Removed  `@Beta`  from  `Multimaps.toMultimap`. ([b6b4dc4](google/guava@b6b4dc4))
-   `collect`: Made the set returned by  `ImmutableMap<K, V>.keySet()`  serializable as long as  `K`  is serializable, even if  `V`  is not (and similarly for  `values()`). ([f5a69c3](google/guava@f5a69c3))
-   `collect`: Fixed bug in  `powerSet.equals(otherPowerSet)`  would erroneously return  `false`  if the two power sets' underlying sets were equal but had a different iteration order. ([215b1f0](google/guava@215b1f0))
-   `collect`: Eliminated  [j2objc](https://developers.google.com/j2objc)  retain-cycle in  `SingletonImmutableBiMap`. ([0ad38b8](google/guava@0ad38b8))
-   `eventbus`: Prevented  `@Subscribe`  from being applied to a method that takes a primitive, as that will never be called. ([554546c](google/guava@554546c))
-   `graph`: Made  `Traverser.breadthFirst()`  lazier, and optimized  `Traverser`  more generally. ([32f2d77](google/guava@32f2d77),  [b5210ca](google/guava@b5210ca))
-   `graph`: Added  `@DoNotMock`  to  `Traverser`. ([6410f18](google/guava@6410f18))
-   `io`: Deprecated  `Files.createTempDir()`. ([fec0dbc](google/guava@fec0dbc)) ([CVE-2020-8908](https://nvd.nist.gov/vuln/detail/CVE-2020-8908); continuing discussion in  [#4011](google/guava#4011))
-   `io`: Upgraded  `ByteStreams.copy(InputStream, OutputStream)`  to use the faster  `FileChannel`  if possible. ([a1e9a0b](google/guava@a1e9a0b))  [update: My mistake: This was  [rolled back](google/guava@e839f94), so it did not make 30.0.]
-   `math`: Added  `roundToDouble`  to  `BigDecimalMath`,  `BigIntegerMath`, and  `LongMath`. ([bee4f3c](google/guava@bee4f3c),  [2b5c096](google/guava@2b5c096),  [633abf2](google/guava@633abf2))
-   `net`: Added  `MediaType`  constants for several font/ types. ([571cf66](google/guava@571cf66))
-   `net`: Added  `HttpHeaders`  constants for  `Cross-Origin-Embedder-Policy(-Report-Only)?`. ([c3bf731](google/guava@c3bf731))
-   `testing`: Made  `EqualsTester`  test that non-`String`  objects are not equal to their  `String`  representations. ([c9570ea](google/guava@c9570ea))
-   `util.concurrent`: Added  `ClosingFuture`. ([52e048e](google/guava@52e048e))
-   `util.concurrent`: Removed the deprecated 1-arg  `ServiceManager.addListener(Listener)`. Use the 2-arg  `addListener(Listener, Executor)`  overload, setting the executor to  `directExecutor()`  for equivalent behavior. ([dfb0001](google/guava@dfb0001))
-   `util.concurrent`: Changed  `AbstractFuture.toString()`  to no longer include the  `toString()`  of the result. ([2ebf27f](google/guava@2ebf27f))
-   `util.concurrent`: Added  `awaitTerminationUninterruptibly`. ([f07b954](google/guava@f07b954))
@eperret eperret added the dependencies Pull requests that update a dependency file label Jul 22, 2021
@eperret eperret requested review from fredboyle and a team as code owners July 22, 2021 21:48
@eperret eperret self-assigned this Jul 22, 2021
@eperret eperret changed the title chore: Bumps [guava]([200~https://github.com/google/guava) from 29-jre to 30.1.1-jre chore: Bumps [guava]([https://github.com/google/guava) from 29-jre to 30.1.1-jre Jul 22, 2021
@eperret eperret changed the title chore: Bumps [guava]([https://github.com/google/guava) from 29-jre to 30.1.1-jre chore: Bumps [guava](https://github.com/google/guava) from 29-jre to 30.1.1-jre Jul 22, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #28 (775abf3) into master (bedaefd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #28   +/-   ##
=========================================
  Coverage     95.29%   95.29%           
  Complexity     2253     2253           
=========================================
  Files           185      185           
  Lines          5673     5673           
  Branches        732      732           
=========================================
  Hits           5406     5406           
  Misses           81       81           
  Partials        186      186           
Flag Coverage Δ
unittests 95.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bedaefd...775abf3. Read the comment docs.

@eperret eperret merged commit f317eed into salesforce:master Jul 22, 2021
@eperret eperret deleted the bump branch July 22, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants