-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dummy password hasher in tests #4083
Use dummy password hasher in tests #4083
Conversation
FYI @akjanik @NyanKiyoshi |
Codecov Report
@@ Coverage Diff @@
## master #4083 +/- ##
=========================================
Coverage ? 91.56%
=========================================
Files ? 277
Lines ? 15106
Branches ? 1474
=========================================
Hits ? 13832
Misses ? 877
Partials ? 397 Continue to review full report at Codecov.
|
algorithm, dummy_password = encoded.split('$') | ||
return OrderedDict([ | ||
(_('algorithm'), algorithm), | ||
(_('hash'), dummy_password)]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are undefined (_
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed it in #3852 (it was failing the checks, thus blocking me from committing).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NyanKiyoshi good catch. Thanks!
This changes will reduce the time of tests execution (#2120).
I know that the above results can be not very precise but I hope that all of us will see the differences.