Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dummy password hasher in tests #4083

Merged
merged 2 commits into from
May 8, 2019
Merged

Use dummy password hasher in tests #4083

merged 2 commits into from
May 8, 2019

Conversation

korycins
Copy link
Member

@korycins korycins commented May 8, 2019

This changes will reduce the time of tests execution (#2120).

Config Master Branch
-n=2 --reuse-db;, docker 1cpu, 1gb ram 302.81s 167.61s
-n=4 --reuse-db;, docker 1cpu, 2gb ram 250.28s 145.44s

I know that the above results can be not very precise but I hope that all of us will see the differences.

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@korycins korycins self-assigned this May 8, 2019
@korycins
Copy link
Member Author

korycins commented May 8, 2019

FYI @akjanik @NyanKiyoshi

@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@8073d95). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4083   +/-   ##
=========================================
  Coverage          ?   91.56%           
=========================================
  Files             ?      277           
  Lines             ?    15106           
  Branches          ?     1474           
=========================================
  Hits              ?    13832           
  Misses            ?      877           
  Partials          ?      397

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8073d95...17bc59f. Read the comment docs.

@maarcingebala maarcingebala merged commit 20fb40b into saleor:master May 8, 2019
algorithm, dummy_password = encoded.split('$')
return OrderedDict([
(_('algorithm'), algorithm),
(_('hash'), dummy_password)])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are undefined (_).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it in #3852 (it was failing the checks, thus blocking me from committing).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NyanKiyoshi good catch. Thanks!

@korycins korycins deleted the use_dummy_password_hasher_in_tests branch October 22, 2019 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants