Performance: Do not store attribute in TIFF new API #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since JpegImagePlugin does not make use of it, it feel safe here. However, other plugin might be using it…
Codecov Report
@@ Coverage Diff @@
## master #365 +/- ##
==========================================
+ Coverage 87.38% 87.46% +0.07%
==========================================
Files 18 18
Lines 1443 1460 +17
==========================================
+ Hits 1261 1277 +16
- Misses 182 183 +1
Continue to review full report at Codecov.
|
|
The above PR is much better, since it includes this current patch, along with other improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The end of my current performance improvement, after #362, #363 and #364.
This one should not be merged as-is for the following reasons:
v2TIFF API in thev1API. It is completely safe for JpegImagePlugin, which makes only use of it, but I don't know the status of other plugins.However, I exposed this to show that on my gallery with 536 images and 46 videos, I'm experiencing a boost of 32% in speed for idle builds.
With all other mentionned patches, I'm going from idle build in 3.23 seconds in master to 1.06 second. It is roughly one-third of the current situation.
Sometimes, it seems that Pillow is not focused on speed, so that's why monkey patching could be allowed (e.g. for #363). This one could be proposed as an option in the configuration.