Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

Update to Wepback 3 #373

Merged
merged 6 commits into from Jul 14, 2017
Merged

Update to Wepback 3 #373

merged 6 commits into from Jul 14, 2017

Conversation

pirelenito
Copy link
Member

@pirelenito pirelenito commented Jun 20, 2017

The biggest improvement it brings is scope hoisting:

Because scope hoisting will remove function wrappers around your modules, you may see some small size improvements. However, the significant improvement will be how fast the JavaScript loads in the browser.

For more information check: https://medium.com/webpack/webpack-3-official-release-15fd2dd8f07b

And although it is a major release of Webpack, it isn't exactly an API breaking change, so upgrading should be fairly smooth. I guess the v9 release will be outpaced pretty quickly.

@pirelenito pirelenito added the wip label Jun 20, 2017
@pirelenito pirelenito requested a review from npejo June 20, 2017 17:46
@pirelenito
Copy link
Member Author

@npejo you have a pretty big project with Sagui, could you try it out and post what improvements it brings in comparison with v9? ❤️

@pirelenito pirelenito removed the wip label Jun 20, 2017
@pirelenito
Copy link
Member Author

It looks like we might encounter an issue: https://mobile.twitter.com/i/web/status/877378116028514304

@pirelenito
Copy link
Member Author

@npejo
Copy link
Member

npejo commented Jun 21, 2017

Thanks for preparing this branch @pirelenito, I will check it on our project.

@xaviervia
Copy link
Member

I’m labeling this as in progress until we investigate that issue more

@xaviervia xaviervia added the wip label Jun 21, 2017
@pirelenito pirelenito changed the base branch from v9 to v10 June 30, 2017 14:11
@pirelenito
Copy link
Member Author

We're just waiting for the 3.0.0 release of extract-text-webpack-plugin, that should be out by tomorrow.

@pirelenito pirelenito added this to the v11 milestone Jul 14, 2017
@pirelenito pirelenito changed the base branch from v10 to v11 July 14, 2017 11:19
@pirelenito pirelenito merged commit 44283e7 into v11 Jul 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants