Skip to content

Commit

Permalink
tests: ignoring 2 tests due to dead servers
Browse files Browse the repository at this point in the history
the two "expected-to-fail" tests fail due to dead servers.
these needs to be fixed but are ignored now in favor of security
  • Loading branch information
aviadhahami authored and saghul committed Jun 21, 2022
1 parent 8026e66 commit faab689
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions tests/tests.py
Expand Up @@ -324,6 +324,11 @@ def cb(result, errorno):
self.assertEqual(type(r), pycares.ares_query_txt_result)
self.assertIsInstance(r.text, str) # it's ASCII

# The 2 tests below hit a dead end thus fail. Commenting for now as I couldn't find a live server
# that satisfies what the tests are looking for

# FIXME: wide.com.es is a dead end!
@unittest.expectedFailure
def test_query_txt_bytes2(self):
self.result, self.errorno = None, None
def cb(result, errorno):
Expand All @@ -335,6 +340,8 @@ def cb(result, errorno):
self.assertEqual(type(r), pycares.ares_query_txt_result)
self.assertIsInstance(r.text, bytes)

# FIXME: "txt-non-ascii.dns-test.hmnid.ru" is a dead end!
@unittest.expectedFailure
def test_query_txt_multiple_chunked_with_non_ascii_content(self):
self.result, self.errorno = None, None
def cb(result, errorno):
Expand Down

0 comments on commit faab689

Please sign in to comment.