Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation guide: Do not recommend --prefix=$CONDA_PREFIX #38017

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented May 17, 2024

Sage packages can clobber installed non-Python conda packages.
Instead we change it to recommend --with-sage-venv=$CONDA_PREFIX and to put SAGE_LOCAL in a subdirectory of the CONDA_PREFIX.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented May 17, 2024

Documentation preview for this PR (built with commit 45e2591; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kwankyu
Copy link
Collaborator

kwankyu commented May 25, 2024

While we are at it, would you unindent the surrounding block (which is shown as quoted text, unintentionally I think) here and below?

@kwankyu
Copy link
Collaborator

kwankyu commented May 25, 2024

Sorry but would you explain how "clobber" happens and why the change in this PR solves the problem?

@kwankyu
Copy link
Collaborator

kwankyu commented May 26, 2024

Now

                    --with-sage-venv=$CONDA_PREFIX 

seems reasonable to me.

Is there an argument to prefer

                    --prefix=$CONDA_PREFIX/libexec/sage-local

than other choices, such as $CONDA_PREFIX/share/sage/local?

@kwankyu
Copy link
Collaborator

kwankyu commented May 26, 2024

Sorry but would you explain how "clobber" happens and why the change in this PR solves the problem?

I think I can answer this. Previously sage installs files into $CONDA_PREFIX/share, and these files may conflict with files that conda itself manages.

$CONDA_PREFIX/share/sage/local ?

Then this also could be problematic...

@kwankyu
Copy link
Collaborator

kwankyu commented May 26, 2024

We may just create a new directory instead of treading into conda areas. How about

--prefix=$CONDA_PREFIX/sage/local

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants