DualMatroid: Add is_valid and relabel methods
#38013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 54777b5; changes) is ready! 🎉 |
tscrim
approved these changes
May 16, 2024
gmou3
force-pushed
the
dual_relabel_and_is_valid
branch
from
3057825
to
54777b5
Compare
tscrim
added
t: enhancement
s: positive review
and removed
t: performance
v: moderate
labels
|
LGTM. Thanks. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 18, 2024
Implement class-specific `is_valid` and `relabel` methods.
Previously, such functionality was achieved through the generic and very
slow rank-based algorithms.
The PR also does a touch-up of the docstrings of `dual_matroid.py`.
URL: sagemath#38013
Reported by: gmou3
Reviewer(s): gmou3, Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement class-specific
is_validandrelabelmethods.Previously, such functionality was achieved through the generic and very slow rank-based algorithms.
The PR also does a touch-up of the docstrings of
dual_matroid.py.