Sheaf cohomology for projective schemes (alternative implementation) #38003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>
…ing resolutions to hash.
|
I need to add a few more doctests, but I will do so tomorrow. |
5 tasks
|
Documentation preview for this PR (built with commit 286e23b; changes) is ready! 🎉 |
|
Okay, this is now ready. I came across that the resolutions were not hashable with a good comparison, so I had to implement those. I removed most of the marcos as they could conflict with other reasonable macros (e.g., the octonians or positive integers). IMO it is best to just write out a few extra characters in the docstrings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative implementation of #37477 based on that branch.
📝 Checklist
⌛ Dependencies