-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Burnside ring of a group #37991
base: develop
Are you sure you want to change the base?
The Burnside ring of a group #37991
Conversation
…groups Also added various miscellaneous functions
Documentation preview for this PR (built with commit f617657; changes) is ready! 🎉 |
Co-authored-by: Martin Rubey <axiomize@yahoo.de>
Also some fixes to _element_constructor_ ConjugacyClassesOfSubgroups
@trevorkarn, I'm adding you here because of your request at #35475 (comment) The current branch is a prototype, not yet ready for review. |
Added _repr_ for ConjugacyClassesOfSubgroups I now output B[(gens or name if available)] as _repr_ for generators, for example B[1] + 2*B[(2,3,4)]
…y and doctest updates
Thanks so much @mantepse! Just let me know when it is ready for review. |
Not sure what exactly you mean here.
|
Ah, I see, that makes sense. |
I propose we implement the conjugacy class renaming like |
Maybe, I don't know. I think we can delay thinking about this until we start to play with species. |
src/sage/rings/burnside.py
Outdated
sage: Z4 in B._indices | ||
True | ||
""" | ||
return H.is_subgroup(self._G) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return H.is_subgroup(self._G) | |
if parent(H) == self: | |
return True | |
return (isinstance(H, PermutationGroup_generic) | |
and H.is_subgroup(self._G)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from sage.structure.element import parent as get_parent_of
was required, then if get_parent_of(H) == self
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry, yes. Except the renaming, this is unnecessary.
Does this use tables of marks? (With which it's much easier). GAP does have functionality to deal with tables of marks, |
Not yet, but eventually we will use it whenever available. However, as you certainly know, the table of marks works is only available for relatively small groups, e.g. the symmetric groups up to |
Why are we adding |
You are right, For me, the only question is whether we need this class at all, and I think that we do. |
If we use the |
Yes, that's correct, and that's the whole point of having a class |
Resolves #35475.
We implement the Burnside ring for a group$G$ . We provide a few ways to construct elements, either directly as a formal sum of orbit types $[G/H]$ (where $H$ is a subgroup of $G$ ), or by providing a group action $\alpha: G \times X \rightarrow X$ on some set $X$ . Finally, we implement addition and multiplication of ring elements.
📝 Checklist
@mantepse