Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Build&Test: Replace use of sage -t --new #37988

Merged
merged 9 commits into from
Jun 1, 2024

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented May 12, 2024

Fixes #37985.

We also turn on --long --format github for this run, so that annotations are shown in the "Files changed" tab.
(Previously, only the annotations from the full testsuite run were shown, out of the concern of duplicating the numerous doctest style warnings. But these warnings have been much reduced, and the last two warnings are fixed in #38029.)

Example run: https://github.com/sagemath/sage/actions/runs/9198070834/job/25299950120?pr=37988

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented May 12, 2024

Documentation preview for this PR (built with commit abcb197; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe mkoeppe force-pushed the ci_build_test_new branch 2 times, most recently from c8cdbc4 to 8717183 Compare May 16, 2024 16:56
@mkoeppe mkoeppe requested a review from vbraun May 18, 2024 00:13
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 18, 2024
@mkoeppe mkoeppe requested review from tscrim and fchapoton May 19, 2024 21:20
@mkoeppe mkoeppe added the p: CI Fix merged before running CI tests label May 24, 2024
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. LGTM.

@mkoeppe
Copy link
Member Author

mkoeppe commented May 28, 2024

Thanks!

vbraun pushed a commit to vbraun/sage that referenced this pull request May 29, 2024
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Fixes sagemath#37985.

We also turn on  `--long --format github` for this run, so that
annotations are shown in the "Files changed" tab.
(Previously, only the annotations from the full testsuite run were
shown, out of the concern of duplicating the numerous doctest style
warnings. But these warnings have been much reduced, and the last two
warnings are fixed in sagemath#38029.)

Example run: https://github.com/sagemath/sage/actions/runs/9198070834/jo
b/25299950120?pr=37988

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#37926 (merged here)
    
URL: sagemath#37988
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
@vbraun vbraun merged commit 1bc9050 into sagemath:develop Jun 1, 2024
17 checks passed
@mkoeppe mkoeppe deleted the ci_build_test_new branch June 1, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Build&Test: Replace use of sage -t --new by explicit file list
3 participants