Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Build&Test: Replace use of sage -t --new by explicit file list #37985

Closed
mkoeppe opened this issue May 11, 2024 · 0 comments · Fixed by #37988
Closed

CI Build&Test: Replace use of sage -t --new by explicit file list #37985

mkoeppe opened this issue May 11, 2024 · 0 comments · Fixed by #37988
Milestone

Comments

@mkoeppe
Copy link
Member

mkoeppe commented May 11, 2024

The current method, using git reset to mark what's new in the PR and then relying on sage -t --new, does not handle file deletions/renames correctly, as observed in #37839 (comment)

Instead we should obtain the list of files changed relative to the base of the PR.

@mkoeppe mkoeppe added this to the sage-10.4 milestone May 14, 2024
vbraun pushed a commit to vbraun/sage that referenced this issue May 29, 2024
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Fixes sagemath#37985.

We also turn on  `--long --format github` for this run, so that
annotations are shown in the "Files changed" tab.
(Previously, only the annotations from the full testsuite run were
shown, out of the concern of duplicating the numerous doctest style
warnings. But these warnings have been much reduced, and the last two
warnings are fixed in sagemath#38029.)

Example run: https://github.com/sagemath/sage/actions/runs/9198070834/jo
b/25299950120?pr=37988

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#37926 (merged here)
    
URL: sagemath#37988
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this issue May 31, 2024
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Fixes sagemath#37985.

We also turn on  `--long --format github` for this run, so that
annotations are shown in the "Files changed" tab.
(Previously, only the annotations from the full testsuite run were
shown, out of the concern of duplicating the numerous doctest style
warnings. But these warnings have been much reduced, and the last two
warnings are fixed in sagemath#38029.)

Example run: https://github.com/sagemath/sage/actions/runs/9198070834/jo
b/25299950120?pr=37988

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#37926 (merged here)
    
URL: sagemath#37988
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant