Adds patch-package to apply fix for Arbitrum Nitro
#701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penandlim
requested review from
hannespfeiffer,
arthur-zhuk and
lilPlumberBoy
hannespfeiffer
approved these changes
Sep 7, 2022
penandlim
added a commit
that referenced
this pull request
Sep 13, 2022
penandlim
added a commit
that referenced
this pull request
Sep 14, 2022
…#684) * adding files is state where tests work * root gauge factory tests, child gauge factory initialize * child gauge initial tests * added oracles and arbitrum bridger * fixed oracles and added test for oracle * updated todo comments * updated Anycall translator and anycall mock contracts * added rootgaugeFactory tests * updated mock anycall contract * updated translator / mock anycall contracts * finalized AnycallTranslator contract * updated translator contract with all accepted function calls * finalized oracle contracts * finalized gauge implementations * added Optimism bridger, cleaned up comments * removed delegatecall from translator * naming changes * Script for enabling on chain gauge voting (#691) * updated logic of RootGauge * added logic for having a RootGauge name * fixed typing of name(), added to factory tests * updated tests to successfully deploy root gauge * Added to RootGauge Factory tests * added deposit and rescue functios to translator * added fixture to RootGauge Factory Test * added todo comments * Add deploy script and deployment data for non-flashloan swaps (#690) * Updates pool reg for FraxBP USDs pool (#686) * updates pool reg for FraxBP USDs pool * ran lint fix * fixed typo in pool registry update * Skip script from running Co-authored-by: Jongseung Lim <penandlim@gmail.com> * Add separate tests for permissionless contracts (#681) * Add separate tests for permissionless contracts * Change test name to be accurate * added deploys for non-flashload permissionless swaps Co-authored-by: Michael Daly <dalymike102@gmail.com> * Fix root gauge factory test. - fix capitalization * Fix capitalization in file names * Fix test imports and types - import from typechain * Lint x chain gauges contracts * Deploy root gauge factory on hardhat * Deploy script for fake USDC (#693) * Run prepare scripts by default on hardhat (#694) * Run prepare scripts by default on hardhat * Specify tags for swapMigrator tests * Fix saving Multicall3 with abi * Ensure no other deploy scripts are ran except the specified * Add the deployed gauge to gauge controller * Updates hardhat and migrate from waffle to hardhat chai matchers (#696) * Migrate from waffle to hardhat chai matchers * Linting fix * Fix function name to include parameters for overloading * Adds 2 new node dependencies (#699) - hardhat-tracer - openzepplin 4.4.0 upgradable * Update AnyCallTranslator to be a proxy. Updates the test. * Change signatures to match up between contracts * Add test for sidechain -> root chain deploy_gauge() * Fix encoding type * Use proxy in deploy script * ChildOracle emits an event when recieving * Cleans up hardhat config file and moves tasks into tasks folder (#698) * Cleans up hardhat config file and moves tasks into tasks folder * Remove unnecessary dependency * Add comments to tasks * Fix param casing * Add deploy scripts for optimism mainnet * Improve fork settings (#700) * Add deploy scripts * Deploy a child gauge for SaddleFRAXBPPoolLPToken * Adds `patch-package` to apply fix for Arbitrum Nitro (#701) * Update USDS pool in pool registry (#702) * Fix duplicate contract names * Add deploy scripts for mainnet. Only run when forking for now * Update RootOracle contract and test * Uses immutables * Removes unnecessary storage var * USDT pool deploy (#703) * Added USDT pool deploy, fixed typo in verify script * deployed to kava_mainnet * fixed registering of pools * registered USDT pool * verified new USDT Pool deployment * Update hardhat to 2.11.1 and associated dependencies (#704) * Update hardhat to 2.11.1 and associated dependencies * Update solidity-coverage package version * Update tests to use the ignore tx type flag * Test for each storage variable separately * Change file name cases to be in consistent style * Update RootGaugeFactory tests * Include prefix and suffix on Gauge names * Update ChildGaugeFactory test * Specify deploy tags for each test (#705) * Use chai's closeTo comparison to approximate * Add appropriate fixture deploy tags to all tests * Increase line coverage * Add tests for collecting fees on PermissionlessMetaSwapFlashLoan instance Co-authored-by: Jongseung (John) Lim <penandlim@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, forking arbitrum is not possible on hardhat 2.10.2.
This commit adds a patch from NomicFoundation/hardhat#2995
https://gist.github.com/gzeoneth/195cb16f00eaa32fa868e6c0192616c1
After running
npm i --legacy-peer-depsArbitrum can be forked with below command.
Once hardhat fixes this issue this patch should be removed.