Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproduce bug where dst leap is passed on to subsequent occurences #647

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

schreven
Copy link

@schreven schreven commented Apr 22, 2024

Part of issue #648

@phil-davis
Copy link
Contributor

phil-davis commented May 7, 2024

@schreven thanks for the test cases.
So the problem is that if a requested event time is in the region 0200 <= time < 0300 then that time does not exist on the morning that "summer time" starts. There is 0159 then straight to 0300 "on the clock".
The event for that day does a reasonable thing. For example, a request for a meeting at 0215 gets scheduled at 0315.

But then that daily event gets scheduled at 0315 on the following days, which is not correct. The event should happen at 0215 (now on the "summer time" clock).

Do you have a suggested fix?

@schreven
Copy link
Author

schreven commented May 7, 2024

Hey @phil-davis, yes you summarized the issue perfectly.

I see that you spotted the issue I created #648 and I continued the discussion there.

Thank you for this library, it's a nice piece of software

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants