Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for string-type parameter VALUE #636

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martijnvankekem
Copy link

See: #635

@staabm
Copy link
Member

staabm commented Jan 17, 2024

please add a test case

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5df355) 98.76% compared to head (3cf6669) 98.76%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #636   +/-   ##
=========================================
  Coverage     98.76%   98.76%           
- Complexity     1866     1867    +1     
=========================================
  Files            71       71           
  Lines          5325     5325           
=========================================
  Hits           5259     5259           
  Misses           66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phil-davis
Copy link
Contributor

@martijnvankekem your PR comes directly from the master branch of your fork, which is a bit more diffcult to manage.
I rebased in a branch in my fork and made and up-to-date PR #640
The CI all passes there - good, no existing test cases were broken.

Please let us know the details of an example iCal structure - what does it pass in $parameters["VALUE"]
It will be good to add a unite test case that has a reasonably realistic example of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants