Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unescaping of URIs in VCard4 and mime type of images in converter #602

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Dec 25, 2022

  1. Unescape also semicolon in URI Property

    This is required for VCard4 (see test sample), as comma and semicolon
    may appear in URIs with scheme data.
    mstilkerich committed Dec 25, 2022
    Configuration menu
    Copy the full SHA
    169e20b View commit details
    Browse the repository at this point in the history
  2. Consider image mime types case insensitive in VCardConverter

    Also added the mandatory escaping of commas in VCard4 prop values to the
    converter test samples.
    mstilkerich committed Dec 25, 2022
    Configuration menu
    Copy the full SHA
    34e3ddd View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2022

  1. Fix: Remove X-ADDRESSBOOKSERVER-KIND=individual property in convert

    When converting to VCard v4, only X-ADDRESSBOOKSERVER-KIND=GROUP is
    converted to KIND=group currently. X-ADDRESSBOOKSERVER-KIND=INDIVIDUAL
    is kept in the vcard, although KIND=individual would be correct. Since
    this is the default, the property can also be dropped, as is done by
    vobject in the opposite direction (converting v4 to v3). Therefore, this
    fix will also drop the X-ADDRESSBOOKSERVER-KIND=INDIVIDUAL property.
    
    Test existing test was broken because it used the output of the v4->v3
    conversion as input for the v3->v4 conversion, but since the property is
    dropped during the first conversion there is no explicit
    X-ADDRESSBOOKSERVER-KIND property in the input of the v3->v4 conversion.
    Test fixed as well.
    mstilkerich committed Dec 26, 2022
    Configuration menu
    Copy the full SHA
    4d89b2e View commit details
    Browse the repository at this point in the history