Update Broker.php, to force the test of ORGANIZER e-mail address to b… #434
Conversation
…e case-insensitive Fixes issue where a recurring meeting is created with ORGANIZER as First.Last@domain.com, then individual appointments are saved with ORGANIZER as first.last@domain.com.
Codecov Report
@@ Coverage Diff @@
## master #434 +/- ##
=========================================
Coverage 98.87% 98.87%
Complexity 1809 1809
=========================================
Files 65 65
Lines 5160 5160
=========================================
Hits 5102 5102
Misses 58 58
Continue to review full report at Codecov.
|
lib/ITip/Broker.php
Outdated
| @@ -847,7 +847,7 @@ protected function parseEventInfo(VCalendar $calendar = null) | |||
| $organizer = $vevent->ORGANIZER->getNormalizedValue(); | |||
| $organizerName = isset($vevent->ORGANIZER['CN']) ? $vevent->ORGANIZER['CN'] : null; | |||
| } else { | |||
| if ($organizer !== $vevent->ORGANIZER->getNormalizedValue()) { | |||
| if (strtolower($organizer) !== strtolower($vevent->ORGANIZER->getNormalizedValue())) { | |||
There was a problem hiding this comment.
Logically doesnt make a difference, but I would use strtoupper as we use in the below lines
There was a problem hiding this comment.
Feel free to change to strtoupper, if you would like.
|
Thx for your PR! Would you mind adding a unit test? |
You're welcome. Unfortunately, I'm a fish-out-of-water when it comes to writing tests... Might be better served with someone who actually knows what they're doing there. |
Co-Authored-By: johnkwoods <john.woods@greatplainsmfg.com>
|
see #435 |
…e case-insensitive
Fixes issue where a recurring meeting is created with ORGANIZER as First.Last@domain.com, then individual appointments are saved with ORGANIZER as first.last@domain.com.