Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty TZID #375

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Empty TZID #375

wants to merge 3 commits into from

Conversation

armetiz
Copy link

@armetiz armetiz commented May 5, 2017

One of our customer export ICS from "Microsoft Corporation//Outlook 14.0 MIMEDIR//EN"
Configured TZID is empty..

BEGIN:VTIMEZONE
TZID:
BEGIN:STANDARD

This commit allow a fallback to the default timezone value instead of a PHP fatal error.

@armetiz
Copy link
Author

armetiz commented May 5, 2017

I just forked from master.. The error is not under my control.

@armetiz
Copy link
Author

armetiz commented Oct 19, 2017

any news ?

@DeepDiver1975
Copy link
Member

Can we get a unit test on this? THX

@armetiz
Copy link
Author

armetiz commented Sep 25, 2018

Hi there.

I'm sorry, I have no time to add unit test for this.

Regards.

@armetiz armetiz force-pushed the patch-1 branch 2 times, most recently from 999ed80 to b6c36b9 Compare June 2, 2020 12:14
@armetiz
Copy link
Author

armetiz commented Jun 2, 2020

test added.

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #375 (2642abe) into master (d8a0a9a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #375   +/-   ##
=========================================
  Coverage     98.73%   98.73%           
- Complexity     1759     1760    +1     
=========================================
  Files            66       66           
  Lines          4279     4279           
=========================================
  Hits           4225     4225           
  Misses           54       54           
Impacted Files Coverage Δ Complexity Δ
lib/TimeZoneUtil.php 97.67% <100.00%> (ø) 24.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8a0a9a...2642abe. Read the comment docs.

@armetiz
Copy link
Author

armetiz commented Apr 30, 2021

patch have be rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants