Pin PHPUnit version to avoid breaking unit tests for PHP 7+ #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerKiKi
force-pushed
the
patch-2
branch
3 times, most recently
from
c0c9df7
to
993f85a
Compare
|
I noticed that PHP 5.5 is still supported by this project even though it reached end of life 8 months ago. I'd strongly suggest getting rid of that support and update to PHPUnit 5.7. Or even consider ditching PHP 5.6 altogether and stick to only 7+ as PHPUnit did themselves 8 months ago. |
|
Superseeded by https://github.com/fruux/sabre-vobject/pull/379 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because PHPUnit recently released a v6 with very important breaking changes, it is required to specify a version to not break our tests. Typically this will solve broken tests as seen in #371.
Also see this excellent explanation as to why composer.lock should be committed.