Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catching another infinite loop condition. #350

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Catching another infinite loop condition. #350

wants to merge 2 commits into from

Conversation

evert
Copy link
Member

@evert evert commented Oct 24, 2016

Fixes #329. Thanks for the research @PHPGangsta

$currentDayOfMonth = $this->currentDate->format('j');
//$currentMonth = $this->currentDate->format('n');
//$currentYear = $this->currentDate->format('Y');
//$currentDayOfMonth = $this->currentDate->format('j');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IF L623-L625 are no longer needed, they should be removed before merging.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha

@alecpl
Copy link
Contributor

alecpl commented Nov 13, 2019

This should be closed in favor of #416.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endless loop in RRuleIterator if BYMONTHDAY does not exist in BYMONTH
4 participants