Merge pull request #619 from sash04ek/patch-3

fixed issue: Undefined index: plusminus #467
sabre-io · Nov 9, 2023 · c832cc3 · c832cc3
2 parents 9341286 + e4d7c4e
commit c832cc3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/DateTimeParser.php b/lib/DateTimeParser.php
@@ -93,7 +93,7 @@ public static function parseDuration(string $duration): \DateInterval
 
         $invert = false;
 
-        if ('-' === $matches['plusminus']) {
+        if (isset($matches['plusminus']) && '-' === $matches['plusminus']) {
             $invert = true;
         }
 

diff --git a/tests/VObject/DateTimeParserTest.php b/tests/VObject/DateTimeParserTest.php
@@ -34,6 +34,12 @@ public function testParseICalendarDurationDateInterval(): void
         self::assertEquals($expected, DateTimeParser::parseDuration('-PT3M'));
     }
 
+    public function testParseDurationZero(): void
+    {
+        $expected = new \DateInterval('PT0S');
+        self::assertEquals($expected, DateTimeParser::parseDuration('P'));
+    }
+
     public function testParseICalendarDurationFail(): void
     {
         $this->expectException(InvalidDataException::class);