chore(docs): fix typos #1536
Merged
chore(docs): fix typos #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1536 +/- ##
=========================================
Coverage 97.22% 97.22%
Complexity 2834 2834
=========================================
Files 175 175
Lines 9018 9018
=========================================
Hits 8768 8768
Misses 250 250 ☔ View full report in Codecov by Sentry. |
phil-davis
approved these changes
Jan 23, 2024
| @@ -101,7 +101,7 @@ public function delete() | |||
| /** | |||
| * Returns the owner principal. | |||
| * | |||
| * This must be a url to a principal, or null if there's no owner | |||
| * This must be an url to a principal, or null if there's no owner | |||
There was a problem hiding this comment.
I guess there is "discussion" about "an url" or "a URL", when pronouncing each letter then it is "a"
"a U, an R and an L". But I will leave this change here - it does not matter either way.
There was a problem hiding this comment.
Good explanation. I did not realized that both variants exist and I should leave it as it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just in documentation.