Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add propFindUnfiltered public method to Client (4.6) #1526

Merged
merged 10 commits into from Dec 11, 2023

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Dec 11, 2023

backport of #1519

To preserve backward-compatibility I added the last commit db80aae in addition to all the commits from master.

The original client propFind function needs to preserve its existing untyped parameters to be strictly backward-compatible.

I added some unit test cases to check what happens when $url is passed as an int (a file called "123456" might be passed as the integer 123456), and what happens when depth of 1 is passes as the string "1". We should let callers still be able to do those things in the current release series.

@phil-davis phil-davis self-assigned this Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (4.6@f2fa433). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff           @@
##             4.6    #1526   +/-   ##
======================================
  Coverage       ?   97.32%           
  Complexity     ?     2836           
======================================
  Files          ?      175           
  Lines          ?     9433           
  Branches       ?        0           
======================================
  Hits           ?     9181           
  Misses         ?      252           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib/DAV/Client.php Outdated Show resolved Hide resolved
@phil-davis phil-davis marked this pull request as ready for review December 11, 2023 12:49
@phil-davis phil-davis merged commit 008ed42 into sabre-io:4.6 Dec 11, 2023
11 checks passed
@phil-davis phil-davis deleted the issue-1041-4.6 branch December 11, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants