fix: restore autoPrefix property of Href #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is the accepted fix, then I will backport it to 4.5 and make a 4.5.1 release. |
use of this property in code was removed in PR sabre-io#801 But the property is left here because old data may still exist that has this property saved. See discussion in sabre-io/Baikal#1154
phil-davis
force-pushed
the
baikal-1154
branch
from
8fecb3e
to
e5395e9
Compare
|
Was is always protected? I don't know right now if unserialize has issues with property access..... |
I copied from what was deleted in: |
|
just looked it up - serialize/unserialize require the access level to be unchanged. |
|
Backported to 4.5 branch in PR #1515 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use of this property in code was removed in PR
#801
But the property is left here because old data may still exist that has this property saved.
See discussion in sabre-io/Baikal#1154
Fixes sabre-io/Baikal#1154 and related issue #1445