Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 4.5.0 #1497

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Release 4.5.0 #1497

merged 3 commits into from
Nov 14, 2023

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Nov 8, 2023 •
edited

fixes #1493

@codecov Codecov
Copy link

codecov bot commented Nov 8, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9fb8b91) 97.32% compared to head (657f61e) 97.32%.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #1497   +/-   ##
=========================================
  Coverage     97.32%   97.32%           
  Complexity     2833     2833           
=========================================
  Files           175      175           
  Lines          9425     9425           
=========================================
  Hits           9173     9173           
  Misses          252      252

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DeepDiver1975 DeepDiver1975 requested review from phil-davis, clxmstaab and staabm and removed request for clxmstaab November 8, 2023 16:20
@tchapi tchapi mentioned this pull request Nov 8, 2023
Closed
@phil-davis
Copy link
Contributor

I will have a look through this today. I am currently going through the other sabre dependencies to make sure that all their CI is working, and see if there are any dependencies that might need a release.
Hopefully can make a release in the coming hours.

@DeepDiver1975 DeepDiver1975 mentioned this pull request Nov 9, 2023
Open
clxmstaab
clxmstaab approved these changes Nov 14, 2023
View reviewed changes
Copy link

@clxmstaab clxmstaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you guys

@phil-davis phil-davis merged commit 7e40343 into master Nov 14, 2023
20 checks passed
@phil-davis phil-davis deleted the release/4.5.0 branch November 14, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@clxmstaab clxmstaab clxmstaab approved these changes

@staabm staabm Awaiting requested review from staabm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New release 4.5.0
3 participants
@DeepDiver1975 @phil-davis @clxmstaab