fix(sync): Fix PHPDoc to allow getChanges for sync to return null #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the comments: "If the syncToken is expired (due to data cleanup) or unknown, you must return null." Signed-off-by: Thomas Citharel <tcit@tcit.fr>
5 tasks
DeepDiver1975
approved these changes
Mar 20, 2023
Codecov Report
@@ Coverage Diff @@
## master #1457 +/- ##
============================================
- Coverage 97.34% 97.21% -0.13%
+ Complexity 2830 2828 -2
============================================
Files 175 175
Lines 9418 8982 -436
============================================
- Hits 9168 8732 -436
Misses 250 250
... and 131 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ChristophWurst
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the comments: "If the syncToken is expired (due to data cleanup) or unknown, you must return null."
Helps with static analysis issues.